19 KiB
19 KiB
VISUAL ANALYSIS - Current vs Proposed Display
HOME PAGE LAYOUT - Current vs Fixed
CURRENT STATE (with bugs)
480x272 pixel display
┌─────────────────────────────────────────────────┐
│ Home [decorative dots] │ ← Header OK
├─────────────────────────────────────────────────┤
│ ☀️ Weather │
│ ┌───────────────────────────────────────────┐ │
│ │ ☀ 15.2°C Mostly Cloudy overlaps→ ❌ │ │ ← TEXT OVERLAP
│ │ 💧 65% 🌀 1013hPa │ Boiler │ │ │ No spacing!
│ │ 💨 8.5km/h ⚡ 45.5kWh │ 19.5° │ │ │ ← TEXT OVERLAP
│ │ │ → 21° │ │ │
│ └───────────────────────────────────────────┘ │
├─────────────────────────────────────────────────┤
│ 🕐 Clock │
│ ┌───────────────────────────────────────────┐ │
│ │ 14:32:45 │ │ ← FROZEN
│ │ Wed, 20 Oct 2024 │ │ (Never updates!)
│ └───────────────────────────────────────────┘ │
├─────────────────────────────────────────────────┤
│ Updated 14:32 RAM:128k TEMP:✓ WiFi:-50dBm MAN │ ← Possible
│ (or overflow if WiFi:-120dBm) │ OVERFLOW ❌
└─────────────────────────────────────────────────┘
PROPOSED STATE (after fixes)
480x272 pixel display
┌─────────────────────────────────────────────────┐
│ Home [decorative dots] │ ← Header OK
├─────────────────────────────────────────────────┤
│ ☀️ Weather │
│ ┌───────────────────────────────────────────┐ │
│ │ ☀ 15.2°C Mostly Cloudy Boiler │ │ ← Proper spacing!
│ │ 💧 65% 🌀 1013hPa 19.5° │ │ Text aligned
│ │ 💨 8.5km/h ⚡ 45.5kWh → 21° │ │ No overlap
│ │ │ │
│ └───────────────────────────────────────────┘ │
├─────────────────────────────────────────────────┤
│ 🕐 Clock │
│ ┌───────────────────────────────────────────┐ │
│ │ 14:32:46 ✓ UPDATES! │ │ ← LIVE TIME
│ │ Wed, 20 Oct 2024 │ │ (Every second!)
│ └───────────────────────────────────────────┘ │
├─────────────────────────────────────────────────┤
│ 🕐 14:32 💾 128k 🌡 19.5° 📡 73% (Excellent) 🔥 ON │ ← Clean,
│ │ no overlap
└─────────────────────────────────────────────────┘
DETAILED COMPARISONS
Weather Panel - Text Overlap Issue
BEFORE (Broken):
Panel: 460px wide
Layout attempt:
[Icon(50px)] [Temp Zone(???)] [Sensor Box(100px)]
↑
Problem: No width calculation!
Real result:
[50px Icon] [Description: "Mostly Cloudy and partly overcast" overlaps]
│↑ This text extends beyond calculated space!
│ Overlaps with: [Sensor Box]
AFTER (Fixed):
Panel: 460px wide
Layout calculation:
[Icon(50px) + gap(10px)] [Temp Zone(260px)] [Sensor Box(100px) + gap(10px)]
↑
Width is known and respected!
Real result:
[50px Icon] [Temp Zone - text truncated if needed]
"Mostly Cloudy..." fits within 260px
[Sensor Box aligned right with proper gap]
Status Bar - Overflow Issue
BEFORE (Can overflow):
Target: 480px total width
Components:
Timestamp: "Updated 14:32:45" = ~110px
Memory: "RAM:1024k" = ~70px
Sensor: "TEMP:✓" = ~60px
WiFi: "WiFi:-120dBm" = ~90px ← LONG if poor signal
Heater: "MAN" = ~40px
MODE CHIP: (fixed right) ~60px
Total: 110 + 70 + 60 + 90 + 40 + 60 = 430px ✓ OK
BUT if WiFi is "-120dBm" instead of "-50dBm":
Total could exceed 480px → TEXT OVERFLOW ❌
Actual problem: No bounds checking!
AFTER (Protected from overflow):
Target: 480px total width
Strategy: Reserve space and fit intelligently
Timestamp: "🕐 14:32" = ~60px
Memory: "💾 128k" or "💾 1.2M" = ~60px (converts MB if large)
Sensor: "🌡 19.5°" not "🌡 ✓" = ~70px (shows value!)
WiFi: "📡 73%" not "-120dBm" = ~50px (percentage, consistent)
Heater: "🔥 MAN" or "❌ OFF" = ~60px (with state and icon)
Reserved for MODE CHIP: ~70px
Total: Max is now predictable and bounded
If any element doesn't fit: gracefully hide less important items
No overflow possible! ✓
Clock Update - Real-time vs Frozen
BEFORE (Frozen):
Timeline at Home Page:
14:32:30 → drawPageHome() called
├─ drawClockPanel() → displays "14:32:30"
├─ drawWeatherPanel()
├─ drawStatusBar()
└─ Page lock acquired for 500ms
14:32:31 → Update arrives (but nav lock active) → BLOCKED
14:32:32 → Update arrives (nav lock expired)
└─ If update called: full page redraw
└─ Otherwise: nothing happens
14:32:45 → User looks at clock
└─ Still shows "14:32:30" ← FROZEN!
└─ User thinks display is broken
14:32:50 → User swipes to next page
└─ Clock updates as part of page navigation
└─ User realizes time WAS updating, but didn't show
Result: Clock appears frozen but isn't really
AFTER (Live every second):
Timeline at Home Page:
14:32:30 → drawPageHome() called
├─ drawClockPanel() → displays "14:32:30"
├─ drawWeatherPanel()
├─ drawStatusBar()
└─ lastHomeSecond = 30
14:32:31 → uiLoop() detects second change
├─ Detects: currentSecond (31) != lastHomeSecond (30)
├─ Only redraws clock panel (partial update!)
├─ Updates display: "14:32:31"
└─ lastHomeSecond = 31
14:32:32 → uiLoop() detects second change
├─ Detects: currentSecond (32) != lastHomeSecond (31)
├─ Only redraws clock panel
├─ Updates display: "14:32:32"
└─ lastHomeSecond = 32
14:32:45 → User looks at clock
└─ Shows "14:32:45" ✓ CORRECT!
└─ User sees live time updating every second
└─ Display appears professional and responsive
Result: Clock is LIVE and RESPONSIVE
Data Update Flow
BEFORE (Blocked updates):
Weather API returns: 22.5°C (new reading)
↓
API callback: updateWeatherOnly(data)
├─ Updates: globalWeather.extTemp = 22.5
├─ Calls: uiRequestRedraw()
│ ├─ Calls: navigateToPage(PAGE_HOME)
│ └─ Check: if (navLocked) return; ← PROBLEM
│ └─ Navigation lock is active (from recent page switch)
│ └─ UPDATE BLOCKED! ❌
↓
User waits 500ms for lock to expire
↓
Next update arrives: 22.6°C
├─ Updates: globalWeather.extTemp = 22.6
├─ Calls: uiRequestRedraw()
│ └─ NOW: Navigation lock expired
│ └─ navigateToPage(PAGE_HOME) allowed
│ └─ Full screen redraw: FLICKER! (entire display redrawn)
↓
User finally sees update but with delay and flicker
Problem: Updates blocked by navigation lock, and full redraws cause flicker
AFTER (Instant updates):
Weather API returns: 22.5°C (new reading)
↓
API callback: updateWeatherOnly(data)
├─ Updates: globalWeather.extTemp = 22.5
├─ Calls: uiRequestHomeUpdate() [NEW FUNCTION]
│ ├─ Bypass: Navigation lock is ignored!
│ ├─ Check: If PAGE_HOME is current
│ ├─ Call: redrawWeatherPanelIfChanged()
│ │ ├─ Compare: extTemp 22.5 vs lastDrawn (22.0)
│ │ ├─ Different! Redraw just this panel
│ │ ├─ No full screen clear
│ │ └─ Partial update: ~50ms vs ~500ms
│ └─ Done! Update complete
↓
User IMMEDIATELY sees: "22.5°C" ✓ No delay
↓
Next update arrives: 22.6°C
├─ Same process
├─ Only weather panel redraws (partial)
├─ No flicker!
└─ Update instant
Result: Instant, smooth, responsive updates with no flicker
DATA FLOW IMPROVEMENTS
Current Architecture
┌──────────────┐
│ API Updates │
│ (Weather, │
│ Boiler) │
└───────┬──────┘
│
↓
┌──────────────────────────────────┐
│ Update Functions │
│ updateWeatherOnly() │
│ updateBoilerData() │
└───────┬──────────────────────────┘
│
↓
┌──────────────────────────────────┐
│ uiRequestRedraw() │
│ (Generic redraw request) │
└───────┬──────────────────────────┘
│
↓
┌──────────────────────────────────┐
│ navigateToPage() │
│ (Full page navigation) │
│ - Checks navigation lock │ ← BLOCKS if locked!
│ - Full screen clear │ ← FLICKER!
│ - Redraw everything │ ← SLOW!
└───────┬──────────────────────────┘
│
↓
┌──────────────────────────────────┐
│ Display Updated (if not blocked) │
└──────────────────────────────────┘
Problems:
× Navigation lock blocks updates
× Full screen redraws cause flicker
× Slow (500-1000ms per update)
× Not suitable for real-time data
Proposed Architecture
┌──────────────┐
│ API Updates │
│ (Weather, │
│ Boiler) │
└───────┬──────┘
│
├─────────────────────────────────────┐
↓ │
┌──────────────────────────────────┐ │
│ Update Functions │ │
│ updateWeatherOnly() │ │
│ updateBoilerData() │ │
└───────┬──────────────────────────┘ │
│ │
├───────────────────────────────────┐│
↓ ││
┌──────────────────────────────────┐││
│ uiRequestHomeUpdate() [NEW] │││
│ (Direct, page-aware update) │││
│ - Bypasses nav lock │││ ← NO BLOCKING!
│ - Only redraws changed panels │││ ← PARTIAL UPDATE!
│ - Fast and efficient │││ ← ~50ms!
└────────┬───────────────────────────┘││
│ ││
┌────────┴────────────────────────┐ ││
↓ ↓ ││
┌───────────────────┐ ┌───────────────────┐
│ Check what changed│ │ Still use nav for │
│ (clock, temp, │ │ manual navigation │
│ humidity, etc) │ │ │
└────────┬──────────┘ └───────────────────┘
│
┌────────┴────────────────────────┐
↓ ↓
┌────────────────────┐ ┌──────────────────────┐
│ Partial Redraws: │ │ Full Redraws still │
│ - Clock Panel │ │ work for nav but │
│ - Weather Panel │ │ with better feedback │
│ - Status Bar │ │ │
│ (Changed regions │ │ │
│ only) │ │ │
└────────┬───────────┘ └──────────────────────┘
│ │
└───────────┬───────────┘
↓
┌──────────────────────────────────┐
│ Display Updated INSTANTLY │
│ No flicker, smooth, responsive │
└──────────────────────────────────┘
Benefits:
✓ No navigation lock blocking
✓ Partial updates (50-100ms)
✓ No flicker
✓ Real-time feel
✓ Efficient rendering
PERFORMANCE COMPARISON
Update Timeline - BEFORE vs AFTER
Scenario: Weather update arrives at 14:32:15
BEFORE (Current):
14:32:15.000 → API response: 22.5°C
14:32:15.005 → updateWeatherOnly() called
14:32:15.010 → Check nav lock: ACTIVE (from page nav at 14:32:00)
14:32:15.011 → Return without update ❌
14:32:15.500 → Lock expires (500ms passed)
14:32:16.100 → Next update arrives: 22.6°C
14:32:16.105 → Nav lock expired, update allowed ✓
14:32:16.110 → Full page redraw starts
14:32:16.600 → Full page redraw complete (~490ms) ← SLOW!
14:32:16.605 → Display shows 22.6°C
Timeline: 1.605 seconds from first update to display
Flicker: YES (entire screen redrawed)
Delay: ~500-1000ms
AFTER (Proposed):
14:32:15.000 → API response: 22.5°C
14:32:15.005 → updateWeatherOnly() called
14:32:15.010 → uiRequestHomeUpdate() called [IGNORES nav lock]
14:32:15.015 → Check if weather changed: YES
14:32:15.020 → Redraw only weather panel (~50ms)
14:32:15.070 → Display shows 22.5°C
Timeline: 0.070 seconds from update to display
Flicker: NO (only panel redrawn)
Delay: ~70ms (instant!)
Next update at 14:32:15.500: 22.6°C
14:32:15.505 → updateWeatherOnly() called
14:32:15.510 → uiRequestHomeUpdate() called
14:32:15.515 → Check if weather changed: YES
14:32:15.520 → Redraw only weather panel (~50ms)
14:32:15.570 → Display shows 22.6°C
Timeline: 0.070 seconds again (consistent!)
Performance Improvement:
- Speed: 20x faster (1600ms → 70ms)
- Smoothness: No flicker vs full-screen flicker
- Consistency: Every update takes same time
TEXT LAYOUT CALCULATION EXAMPLE
Weather Panel Layout Math
BEFORE (No calculation):
Panel width: 460px
Just place elements and hope they fit!
Fixed positions:
- Icon: X=15, W=50
- Temp section: X=80
- Sensor box: X=360, W=100 (assumed to fit)
- Details: Placed below
Problem:
If temp description is "Partly cloudy and overcast with possible showers"
Text extends beyond assumed boundary
Overlaps with sensor box at X=360
No calculation done!
AFTER (Proper calculation):
Panel width: 460px
Panel padding: left=10, right=10 → available=440px
Step 1: Reserve space for critical elements
- Icon: 50px
- Sensor box: 100px
- Gaps and margins: 30px
- Available for text: 440 - 50 - 100 - 30 = 260px
Step 2: Position elements
- Icon: X=15, W=50
- Temp section: X=80, W=260 ← Calculated!
- Sensor box: X=350, W=100 ← Positioned right of temp section
- Details: Below temp section within 260px
Step 3: Truncate text if needed
for (int len = strlen(text); len > 0; len--) {
truncated = text[0..len]
if (getTextWidth(truncated) <= 260) {
strcat(truncated, "...")
break
}
}
Result:
"Partly cloudy and overcast with possible showers"
→ "Partly cloudy and overcast with..." (fits in 260px!)
→ Sensor box never overlaps
All text properly fits within calculated boundaries!
SUMMARY VISUALIZATION
PROJECT STATUS:
Current State:
████████░░░░░░░░░░ 40% (functional but buggy)
Features work but appearance is broken
After Phase 1 Fixes (Critical):
████████████░░░░░░ 65% (visually improved)
Display looks professional, data feels real-time
After Phase 2 Fixes (Polish):
████████████████░░ 85% (production ready)
All UI elements clear and well-designed
After Phase 3 Fixes (Performance):
████████████████████ 100% (premium quality)
Smooth, responsive, professional experience