Deelife-TPMS/bug_report_and_fixes.md

6.8 KiB
Raw Permalink Blame History

Deelife TPMS App — Code Audit & Fix Report

Date: 2026-06-29
Audit Scope: Full codebase (all .kt, .xml, .py files in the project)
Outcome: 9 issues identified (2 critical, 2 high, 3 medium, 2 low). All fixed. APK rebuilt and verified.


🔴 CRITICAL BUGS

1. Status Byte Treated as Single Value Instead of Bitmask

Files affected:

  • app/src/main/java/com/example/tpms/TpmsParser.kt
  • app/src/main/java/com/example/tpms/TpmsService.kt
  • app/src/main/java/com/example/tpms/ui/TpmsUI.kt

Problem: The status byte (byte 6) can hold multiple bit flags simultaneously (e.g., 0x08 = hardware alarm OR 0x01 = low battery → combined value 0x09). The code used equality checks (status == 0x08, status == 0x01), which would miss conditions when both bits are set. A sensor with both a hardware alarm and a low battery would show as "Normal" with no alert.

Fix: Replaced all 6 occurrences of equality checks with bitmask checks:

Location Before After
TpmsParser.kt — low battery detection status == 0x01 (status and 0x01) != 0
TpmsParser.kt — pairing drop check status == 0x08 (status and 0x08) != 0
TpmsParser.kt — pairing rise check status != 0x08 (status and 0x08) == 0
TpmsService.kt — fast leak alarm tire.status == 0x08 (tire.status and 0x08) != 0
TpmsUI.kt — alert detection in card it.status == 0x08 (it.status and 0x08) != 0
TpmsUI.kt — status label in card data.status == 0x08 (data.status and 0x08) != 0

🟠 HIGH-SEVERITY BUGS

2. Alarm Volume Creep — Boosted Indefinitely

File: TpmsService.kt

Problem: Every call to playAlarmSound() read the current alarm volume and added 2 units. The repeating alarm fires every 60 seconds, permanently pushing volume to maximum. The original user volume was never restored.

Fix:

  • Added savedAlarmVolume field (initialized to -1).
  • Save original alarm volume once in startAlarmSound().
  • Only boost volume on the first ping (boostVolume = true). Subsequent repeating pings pass boostVolume = false.
  • Restore original volume in stopAlarmSound().

3. Overlapping Sound Schedules on Alarm Type Change

File: TpmsService.kt

Problem: startAlarmSound() scheduled 3 anonymous ping callbacks at t=0, t=800ms, t=1600ms. When a different alarm type triggered within 1.6s, alarmSoundRunnable was cancelled but the anonymous lambdas could not be removed, causing overlapping pings.

Fix: Replaced anonymous lambdas with named Runnable instances (initialPingRunnable1, initialPingRunnable2) that can be cancelled via mainHandler.removeCallbacks(...) in both startAlarmSound() and stopAlarmSound().


🟡 MEDIUM-SEVERITY BUGS

4. Snooze Label Shows Wrong Text

File: TpmsUI.kt

Problem: When snoozed "until restart" (Long.MAX_VALUE → minutesLeft = -1), the UI displayed "snoozed (done)" which misleadingly suggests the snooze expired. The changelog specified it should show "snoozed (Restart)".

Fix: Changed "snoozed (done)" → "snoozed (Restart)".

5. Broken Test Files (Would Not Compile)

Files:

  • app/src/test/.../MainScreenViewModelTest.kt
  • app/src/androidTest/.../MainScreenTest.kt

Problem: Both tests referenced non-existent types (MainScreenViewModel, MainScreen, MainScreenUiState) — leftover scaffold code from project creation.

Fix:

  • Unit test — Rewrote to test TpmsParser with real protocol frames:
    • Valid frame parsing (pressure/temperature/position)
    • Bad checksum rejection
    • Low battery flag detected via bitmask
    • Combined alarm+battery status (0x09) detected correctly
    • Garbage bytes skipped before valid frame
  • UI test — Rewrote to test TpmsDashboard composable:
    • Title text exists
    • Buttons exist

6. Snooze Event Could Be Silently Dropped

File: TpmsManager.kt

Problem: _alarmSnoozedEvent.tryEmit(Unit) returns false if the SharedFlow buffer is full (extraBufferCapacity = 1). If the collector is suspended or slow, the snooze re-evaluation would never happen.

Fix: Changed to scope.launch { _alarmSnoozedEvent.emit(Unit) } which suspends until the value can be delivered.


🟢 LOW-SEVERITY / DESIGN ISSUES

7. O(n) Buffer Performance

File: TpmsParser.kt

Problem: The parse buffer used mutableListOf<Byte>() with removeAt(0), which is O(n) per removal. While negligible for normal 2-second-8-byte traffic, noisy data could cause jank.

Fix: Replaced with ArrayDeque<Byte>() using removeFirst(), giving O(1) amortized removal.

8. Alarm Priority — Only First Match Reported

File: TpmsService.kt — evaluateAlarms()

Problem: The alarm loop uses break after the first match (ordered: Low Pressure → High Pressure → High Temp → Low Battery → Fast Leak → Slow Leak). A tire with both low pressure AND low battery only reports low pressure.

Status: Not fixed. This is a design trade-off — showing only the highest-priority alarm avoids notification spam. Monitor user feedback to decide if multiple simultaneous alarms should be reported.

9. USB Connection Retry Loop Has Finite Duration

File: TpmsService.kt

Problem: The boot-time retry loop runs repeat(36) with 5-second delays = exactly 3 minutes. After this, only the ACTION_USB_DEVICE_ATTACHED broadcast will trigger reconnection.

Status: Not fixed. The attach broadcast handles post-3-minute scenarios, so this is a non-critical observation.


📊 Summary

# Severity Issue Fixed
1 🔴 Critical Status byte not bitmasked (alarms missed) ✅
2 🟠 High Alarm volume permanently boosted ✅
3 🟠 High Overlapping sound callbacks ✅
4 🟡 Medium Wrong snooze label text ✅
5 🟡 Medium Broken test files ✅
6 🟡 Medium Snooze event could be dropped ✅
7 🟢 Low O(n) buffer performance ✅
8 🟢 Low Single-alarm priority design 🔲
9 🟢 Low Finite retry loop duration 🔲

Files Modified

File Changes
TpmsParser.kt Bitmask checks (×3), ArrayDeque<Byte> buffer, removeFirst() calls
TpmsService.kt Bitmask check, volume save/restore, named ping runnables, boostVolume parameter
TpmsUI.kt Bitmask checks (×2), snooze label text
TpmsManager.kt tryEmit → scope.launch { emit() }
MainScreenViewModelTest.kt Rewritten: 6 unit tests for TpmsParser
MainScreenTest.kt Rewritten: 2 UI tests for TpmsDashboard

Build Result

BUILD SUCCESSFUL in 29s
34 actionable tasks: 14 executed, 19 from cache, 1 up-to-date
APK: tpms-app\app\build\outputs\apk\debug\app-debug.apk